Forums | Mahara Community

Comments on feature proposals /
Make Mahara assignment type work with Moodle 2.3+


Aaron Wells's profile picture
Posts: 896

23 May 2014, 16:38

Yes, I probably should. It may be a bit confusing, though, that there's already a Mahara assignment submission plugin up, from Tony Box: https://moodle.org/plugins/view.php?plugin=assignsubmission_mahara

Cheers,

Aaron

anonymous profile picture
Account deleted
Posts: 34

23 May 2014, 18:46

Hi Aaron,

I'm worried now that you have highlighted the existance of the plugin by Tony Box. Have we (UC) been using a different plugin? Which one is "officially" supported by the community? Is it just that they happened to be developed in parrallel or did they know about each other?

IMHO There should be one plugin supported by MoodleHQ, Catalyst and the community.

It's obvious that otherwise efforts and funds are divided and we end up with different versions that are recourced starved, as with so many other open source projects.

 

Cheers.

anonymous profile picture
Account deleted
Posts: 34

23 May 2014, 18:50

Secondarily, which plugin should we work with for the LTI work?

 

Kristina Hoeppner's profile picture
Posts: 4735

02 June 2014, 20:35

Hello Shane,

The specifications that we had put forward so far for the LTI work was based on the functionality of the "original" Mahara assignment submission plugin which is the one that Ruslan and we have been working on and extended so far. Although once completed, it should also be able to be applied to Tony's plugin as the mechanics of connecting to Moodle would still be the same I assume.

Cheers

Kristina

 

anonymous profile picture
Account deleted
Posts: 34

03 June 2014, 15:13

Thanks Kristina,

I guess my main line of thought has two main threads right now.

1) Will doing the LTI work now, before integrating the two plugins, result in wasted effort. Based on your comments the answer would be no, so thats good.

2) Rather than going forward with "enhancing" Ruslans' plugin as per the current quote - it seems to make more sense to merge the features of Tonys' code instead - ontop of Ruslans' code base that you (Catalyst) are already working with.

What are your thoughts on 2)?

Thanks.

Shane.

Kristina Hoeppner's profile picture
Posts: 4735

08 June 2014, 18:44

Hello Shane,

As mentioned off-forum, Aaron will take a look at the feasibility of merging the code.

Cheers

Kristina

 

Scott Gage's profile picture
Posts: 64

11 June 2014, 11:11

Hi All, not sure if this is the correct place to put this but we have strict standards enabled in our development environment to ensure coding quality and the Mahara assignment plugin is throwing out the following:

Strict Standards: Declaration of assign_submission_mahara::lock() should be compatible with that of assign_submission_plugin::lock() in /m0/moodle/mod/assign/submission/mahara/locallib.php on line 741 Strict Standards: Declaration of assign_submission_mahara::unlock() should be compatible with that of assign_submission_plugin::unlock() in /m0/moodle/mod/assign/submission/mahara/locallib.php on line 741

We're running Moodle 2.6. I've added $flags to the lock and unlock methods (since the default methods have that) but it hasn't removed the message.

Cheers,

Scott

Kristina Hoeppner's profile picture
Posts: 4735

11 June 2014, 13:30

Hello Scott,

Are these warnings in the plugin from the Moodle plugin database or the one from https://github.com/catalyst/assignsubmission_mahara ?

Cheers

Kristina

 

Scott Gage's profile picture
Posts: 64

11 June 2014, 18:46

Hi Kristina,

The errors are being generated by Moodle with the https://github.com/catalyst/assignsubmission_mahara add-in installed.

Cheers,

Scott

Ruslan Kabalin's profile picture
Posts: 146

11 June 2014, 21:22

I have reported the bug: https://github.com/catalyst/assignsubmission_mahara/issues/6, the patch fixing it is in the pull request.