03 November 2022, 1:12

Hi all

I have a Mahara installation that was recently upgraded and now it seems the 'Reply' button on user notifications isn't appearing.

If there are multiple recipients the 'Reply all' button does show but doesn't populate the 'to' field in the reply notification

From the notification page code I can see that the card that renders the notification has the class no-footer in it and I believe it is this class that is 'hiding' the reply icons

In an example on another Mahara install (an older version) that does have working 'Reply' icons the card code contains a <div class="actions card-footer"> div that renders the reply. The no-footer class in the none working example is removing this

In the code I can see the code that adds the no-footer class:

<div class="card-body {if !($item->canreply || $item->canreplyall)} no-footer{/if}">

So Mahara is doing some kind of can reply check which leads me to think it's a setting somewhere

So, the question is (apologies for a long ramble) how do I get the 'Reply' function working again?

Jim

03 November 2022, 11:07

Hi Jim,

What version of Mahara did you upgrade from and to?

Regarding 'Reply' on notifications, are you referring to messages that are sent from 'System' or an account?

Screenshots are helpful too 😊

Kind regards,

Doris

04 November 2022, 4:47

Hi Doris

Thank you for getting back to me

Working version was 21.04.6 - upgraded to 22.04.2

The notifications are user notifications :-)

Here's some screen shots

No reply button:

Apparently I am too new to add images! - I did put one here!

But multiple recipient notification shows Reply all:

...and here 

But when clicking reply all, recipients aren't populated in the 'to' list:

...and here

Version 21.04.6 with working reply button:

...and here :-(

I'm sure it's something to do with this code -> <div class="card-body {if !($item->canreply || $item->canreplyall)} no-footer{/if}"> adding no-footer class into the notification card-body div

Probably a really simple explanation but I am stumped! :-)

Jim

04 November 2022, 4:48

Sorry about lack of images....unfortunately my post wouldn't process with them in!

Jim

09 November 2022, 9:52

Hi Jim,

Please try again. I removed the probation from your account.

Cheers

Kristina

10 November 2022, 1:20

Thank you Kristina

Ok.....here we go with some images :-)

No reply button (personal/user message Mahara version 22.04.2):

But multiple recipient notification shows Reply all:

But clicking the reply all does not populate the recipients list:

Working reply button on Mahara  21.04.6:

As previously mentioned the non-working/existing reply buttons are being hidden by the no-footer class added to the notification card:

<div class="card-body {if !($item->canreply || $item->canreplyall)} no-footer{/if}"> 

Any help, very much appreciated :-)

Jim  

24 November 2022, 13:31

Hi Jim,

Even though I can't replicate the issue locally - can I get you to try this patch https://reviews.mahara.org/c/mahara/+/13493

to see if that makes any difference to you.

Cheers

Robert

25 November 2022, 0:32

Hi Robert

Thank you very much indeed for the response

I'll give it a whirl and report back....fingers crossed! :-)

Thank you

Jim

25 November 2022, 0:49

Hi Robert

Fantastic work, thank you!

I am now seeing the reply button/icon in personal messages :-)

The only thing now is the recipient list isn't populated when you click the reply or the reply all

Is there a fix for this too?

Really appreciate your help here, thank you  

Jim

25 November 2022, 11:21

Hi Jim,

Looking at the code there a number or reasons the recipient list is not populated.

Can you check the state of the following in your site:

1) Is isolated institutions turned on (check htdocs/config.php file)

2) The recipients allow 'Messages from other people' (see account -> settings page)

If none of these apply I suspect there is still a code bug.

I've adjusted the patch to have a new change in it - let me know if that makes any difference

https://reviews.mahara.org/c/mahara/+/13493

Cheers

Robert