Forums | Mahara Community

Developers /
Added Vimeo as External Video type


anonymous profile picture
Deleted user
Posts: 131

17 March 2011, 12:28 PM

Hi all,

I added Vimeo as an embeddable type in the External Video block. It also has an option to retrieve default dimensions using the Vimeo API. (I looked into this for YouTube too, but no default size is reported.)

Please test it if you get a chance and report any issues.

External Video with Vimeo

Make sure to paste in the video's URL, not the embed code.

Best wishes,

Mike

 

EDIT: updated download file.

anonymous profile picture
Deleted user
Posts: 131

17 March 2011, 1:04 PM

I updated the download file- the updated link is:

External Video with Vimeo

Mods please edit post above if possible.

François Marier's profile picture
Posts: 411

17 March 2011, 8:42 PM

Hi Mike,

Thanks for sharing that code. I have cleaned it up a bit and put it up on a git branch here to make it easier to review:

http://gitorious.org/~fmarier/mahara/francois-sandbox/commits/externalvideo-mike

All I did was fix up some whitespace issues and split the changes into 3 different logical commits, which allowed me to cherry-pick this one onto master right away:

http://gitorious.org/~fmarier/mahara/francois-sandbox/commit/e75a622d333c6bf95ab1bb384b180166f6c4baf0

I haven't had time yet to review your patches fully, but I was wondering about this one:

http://gitorious.org/~fmarier/mahara/francois-sandbox/commit/dca099544a0a86512d3a2d5ae543851d8366dd1a

I don't think we want to change the message there because pasting embed code into the URL box does work for all services except Vimeo. In fact, it might be easy to do it for Vimeo too.

By the way, if you want to get started with git and have any questions, let me know :)

Cheers,

Francois

anonymous profile picture
Deleted user
Posts: 131

20 March 2011, 8:25 AM

Thanks for doing that Francois! I'm using svn here, but it would be useful to get up to speed on Git. I will take a look at Gitorious and no doubt ask you a few questions. 

I have various other customisations I can contribute which may or may not be useful for others.

The problem with embed codes is that the default embed code for youtube doesn't work now - they have a new iframe code format which is different from the old object/embed one. Looking at it just now, it looks like it would be quite easy to adapt the External Video block to work with it. 

Vimeo are also now using iframe code but that actually works ok as the required id can still be parsed out of it using the same regular expression.

So we should fix the Youtube embedding rather than change the help text.

Best wishes,

Mike

anonymous profile picture
Deleted user
Posts: 1

27 April 2011, 10:59 AM

Hi,

this is great. How do I install this plugin/ extension? Thanks.

5 results