#1858042
]]>You may take a look at the fix we made a while ago to whitelist more CSS styles. It seems that <pre> is still stripped out / set to "Display: none". I think it would be good to get some more of these allowed and whitelist them properly.
If you'd like to give it a go, you can submit a patch (information on how to connect to code review, please see our documentation). If setting up the connection to code review is too time-consuming at this stage, you can create a new bug and attach the patch there. We will then transfer it to code review. In either case, it would be good if you set up a new bug for the specific fix that you are doing as that helps with tracking the different issues. The tracker item I mentioned above has been released and we do not reopen tracker items that have already been released.
Thank you
Kristina
]]>I'm not using TinyMCE to create the data I'm displaying on the page. I'm writing an HTML file off line and then uploading it to my site files. From there I insert the file into the page as a "Some HTML" block. The file contains a block of text within <pre></pre> tags. I find that if I allow HTMLPurifier to do whatever it does, then the contents inside the pre tags will not display (as in a blank page), but if I comment out the purifier function then the content displays as it should. In the past this has not affected creating or editing skins to my recollection (which may not be so good, I've been using mahara for the very early days). I'm not using mahara in the regular sense, I just use it for personal web pages. I find it much easier than writing my own ;-).
My current work around is to have both the modified purifier file and the original present in the HTMLPurifier directory. I copy the original in place when I want to work with skins and then copy the modified purifier in place when I'm done. Once I have the site where I want it, the need for this work around is no longer needed. So, it's not too much of a bother really. I'm just curious why purifier would seemingly block <pre> tags. Are they a security threat or something?
Thanks for you help
]]>
I note in places where there is the TinyMCE (wysiwyg) editor the is the option to choose 'preformatted' from the paragraph style dropdown and that saves the <pre> tag as expected.
Which form/field are you using to try and save the <pre> tags?
And are you able to give an example of the markup containing <pre> that is not saving as expected?
Cheers
Robert
]]>Is there anyway I can use the purifier and still be able to use the <pre> tag?
TIA
Gary
]]>I'm not able to replicate the problem and that generic error message does not help with diagnosing the problem.
Can I get you to add the changes in https://reviews.mahara.org/#/c/10661/ to your site - they should add to the error message the file and line number that is causing the problem.
If you could do that and paste in the error with file/line number I'll try and workout why it is failing
Cheers
Robert
]]>
<<<
referer: https://domain.tld/view/view.php?id=69
[WAR] e3 (lib/errors.php:536) [Error]: Call to a member function get() on null, referer: https://domain.tld/skin/design.php?id=9
Call stack (most recent first):, referer: https://domain.tld/skin/design.php?id=9
* exception(object(Error)) at Unknown:0, referer: https://domain.tld/skin/design.php?id=9
[php7:notice] , referer: https://domain.tld/skin/design.php?id=9
[php7:notice] [WAR] d2 (lib/errors.php:536) [Error]: Call to a member function get() on null, referer: https://domain.tld/skin/design.php
[php7:notice] Call stack (most recent first):, referer: https://domain.tld/skin/design.php
[php7:notice] * exception(object(Error)) at Unknown:0, referer: https://domain.tld/skin/design.php
[php7:notice] referer: https://domain.tld/skin/design.php
>>>
Can you help me solve this?
TIA
]]>